Merged
Conversation
neilvcarvalho
force-pushed
the
nc-update-dependencies
branch
4 times, most recently
from
ca67cbf to
e7fe15f
Compare
Member
Author
|
I just noticed a very important notice on the Appraisals README.md:
That makes things way easier. |
We've been ignoring an important note from the Appraisals README: > When using Appraisal, we recommend you check in the Gemfiles that Appraisal generates within the gemfiles directory, but exclude the lockfiles there (*.gemfile.lock.) The Gemfiles are useful when running your tests against a continuous integration server. Removing the gemfiles makes things way easier for us, since each Ruby version will resolve the dependencies based on their restrictions.
neilvcarvalho
force-pushed
the
nc-update-dependencies
branch
from
5487cad to
2c5c050
Compare
neilvcarvalho
force-pushed
the
nc-update-dependencies
branch
from
2c5c050 to
05425ed
Compare
neilvcarvalho
commented
Jan 24, 2025
| @@ -0,0 +1,6 @@ | |||
| # Auto generated files with errors to ignore. | |||
Member
Author
There was a problem hiding this comment.
An alternative to adding a TODO file is locking standard to a specific version. I added this because it's outside the scope of this PR.
seanpdoyle
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some outdated dependencies, and are seeing failures on the CI environment for Rails 6.1.
Most of the errors happened due to locked dependencies that are incompatible with some Ruby versions. That was happening because we added the Appraisals lockfiles to the version control, which isn't recommended. Each Ruby version (combined with each Appraisal) should resolve the dependencies themselves, downloading the latest compatible version.
I also updated all dependencies from the gemspec to their latest version. From now on, Dependabot should pick whatever dependencies are updated and we'll know if some of them broke anything. The dependencies were updated using Ruby 3.3, as Ruby 3.4 has a failed spec that I'll investigate in the near future.