Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
🧱 Terraform, Security & Lab Updates
📘 Documentation Enhancements
🛠️ Script Overhauls
This pull request introduces significant updates to the Azure setup and Terraform workflows for the "DevOps The Hard Way - Azure" project. Key changes include enhancements to security and automation in Terraform workflows, improved documentation for labs, and the addition of robust scripts for Azure resource provisioning. Below are the most important changes, grouped by theme:
Terraform Workflow Enhancements
.github/workflows/main.ymlto support OpenID Connect (OIDC) for Terraform authentication, replacing the use of client secrets. Addedid-token: writepermission and theARM_USE_OIDCenvironment variable.1.11.0and added steps for rendering Terraform documentation (terraform-docs) and performing security scans (tfsec) in the CI pipeline.init,plan,apply, etc.) explicitly set the working directory to./2-Terraform-AZURE-Services-Creation/4-aksfor consistency. [1] [2]Documentation Improvements
1-Configure-Terraform-Remote-Storage.mdlab by adding prerequisites (e.g., Contributor permissions) and detailing security measures like encryption, TLS enforcement, and resource locks for Azure Storage Accounts. [1] [2] [3]2-Create-Azure-AD-Group-AKS-Admins.mdlab with clearer prerequisites and best practices, including Conditional Access policies and Privileged Identity Management (PIM). [1] [2]1-Azure/README.md) to summarize the purpose of the Azure setup, list labs, and highlight best practices like RBAC and Infrastructure as Code.Script Enhancements
create-terraform-storage.shscript with a more robust version (1-create-terraform-storage.sh) that includes error handling, enhanced security configurations (e.g., TLS 1.2, public access disabled), and detailed Terraform backend output. [1] [2]create-azure-ad-group.shscript with an improved version (2-create-azure-ad-group.sh) that adds descriptive metadata, checks for existing resources, and outputs the Azure AD Group ID in a user-friendly format. [1] [2]Terraform Configuration and Lab Updates
1-Create-ACR.md) to include additional prerequisites (e.g., Azure CLI) and best practices such as using Managed Identity for authentication and implementing retention policies for cost optimization. [1] [2]These changes enhance the project's security, maintainability, and usability, aligning with best practices for Azure and Terraform workflows.