Fix unreadable text on disabled secondary outline buttons in Lux theme#1353
Open
aaronhudon-pq wants to merge 1 commit intothomaspark:v4from
Open
Fix unreadable text on disabled secondary outline buttons in Lux theme#1353aaronhudon-pq wants to merge 1 commit intothomaspark:v4from
aaronhudon-pq wants to merge 1 commit intothomaspark:v4from
Conversation
The Bootswatch Lux theme overrides the base `.btn-outline-secondary` styling but fails to provide specific overrides for the `.disabled` class and `:disabled` pseudo-class. Because of this omission, disabled buttons fall back to the default Bootstrap styles (white text on a transparent background), making the text invisible against light backgrounds. Added explicit CSS/SCSS rules for `.btn-outline-secondary.disabled` and `&:disabled` to maintain the expected gray text color (`$gray-600`) and transparent background, while still inheriting Bootstrap's default disabled opacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bootswatch Lux theme overrides the base
.btn-outline-secondarystyling but fails to provide specific overrides for the.disabledclass and:disabledpseudo-class. Because of this omission, disabled buttons fall back to the default Bootstrap styles (white text on a transparent background), making the text invisible against light backgrounds.Added explicit CSS/SCSS rules for
.btn-outline-secondary.disabledand&:disabledto maintain the expected gray text color ($gray-600) and transparent background, while still inheriting Bootstrap's default disabled opacity.