Add FIXME comments to places accessing undefined variables#2148
Open
fingolfin wants to merge 5 commits intothofma:masterfrom
Open
Add FIXME comments to places accessing undefined variables#2148fingolfin wants to merge 5 commits intothofma:masterfrom
fingolfin wants to merge 5 commits intothofma:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 77.28% 77.28% -0.01%
==========================================
Files 381 381
Lines 120712 120712
==========================================
- Hits 93298 93293 -5
- Misses 27414 27419 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not necessarily for merging, but rather a way to flag these spots in the code, in the hopes that people who understand the code can then fix it.