Skip to content

feat: embedded (finitely generated torsion-free) modules#1955

Draft
thofma wants to merge 6 commits intomasterfrom
th/embedded
Draft

feat: embedded (finitely generated torsion-free) modules#1955
thofma wants to merge 6 commits intomasterfrom
th/embedded

Conversation

@thofma
Copy link
Copy Markdown
Owner

@thofma thofma commented Aug 22, 2025

Example:

julia> M = Hecke.embedded_module(ZZ, QQ[1 2//3; 3 4]);

julia> N = Hecke.embedded_module(ZZ, QQ[0 1; 0 0]);

julia> intersect(M, N)
Embedded module over Integer ring with generator matrix
[0   -2]
[0    0]

BMint = numerator(d * BM)
BNint = numerator(d * BN)
H = vcat(BMint, BNint)
@info H
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info not vprint?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 23.77622% with 872 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.45%. Comparing base (8dc12cc) to head (eb28a24).
⚠️ Report is 193 commits behind head on master.

Files with missing lines Patch % Lines
src/AssociativeAlgebraOrder/Basics.jl 20.48% 462 Missing ⚠️
src/AssociativeAlgebraOrder/Elem.jl 0.00% 215 Missing ⚠️
src/AssociativeAlgebraOrder/Types.jl 10.34% 78 Missing ⚠️
src/Misc/embedded_modules.jl 68.87% 47 Missing ⚠️
src/LinearAlgebra/FakeFmpqMat.jl 28.57% 35 Missing ⚠️
src/Misc/fraction_field.jl 21.42% 22 Missing ⚠️
src/Misc/Matrix.jl 70.58% 5 Missing ⚠️
src/GenOrd/Auxiliary.jl 0.00% 4 Missing ⚠️
src/AlgAssAbsOrd/Ideal.jl 0.00% 3 Missing ⚠️
src/NumFieldOrd/NfOrd/LinearAlgebra.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
- Coverage   76.97%   76.45%   -0.53%     
==========================================
  Files         363      368       +5     
  Lines      116407   117542    +1135     
==========================================
+ Hits        89601    89861     +260     
- Misses      26806    27681     +875     
Files with missing lines Coverage Δ
src/Hecke.jl 51.71% <ø> (ø)
src/NumFieldOrd/NfOrd/NfOrd.jl 86.88% <100.00%> (+0.05%) ⬆️
src/NumFieldOrd/NfOrd/LinearAlgebra.jl 60.22% <66.66%> (+1.50%) ⬆️
src/AlgAssAbsOrd/Ideal.jl 81.51% <0.00%> (-0.20%) ⬇️
src/GenOrd/Auxiliary.jl 88.16% <0.00%> (-2.14%) ⬇️
src/Misc/Matrix.jl 76.59% <70.58%> (-0.29%) ⬇️
src/Misc/fraction_field.jl 21.42% <21.42%> (ø)
src/LinearAlgebra/FakeFmpqMat.jl 49.62% <28.57%> (-4.51%) ⬇️
src/Misc/embedded_modules.jl 68.87% <68.87%> (ø)
src/AssociativeAlgebraOrder/Types.jl 10.34% <10.34%> (ø)
... and 2 more

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants