Conversation
thofma
commented
Mar 31, 2025
thofma
commented
Mar 31, 2025
src/NumField/Subfields.jl
Outdated
| cur_b = Vector{Int}[intersect(x, y) for x in cur_b for y in all_b[i]] | ||
| cur_b = Vector{Int}[x for x in cur_b if length(x) > 0] | ||
| j = 1 | ||
| while block_system(pe + j*as[i], C) != c |
Collaborator
There was a problem hiding this comment.
cur_b - it was renamed a couple of times
fieker
reviewed
Apr 1, 2025
fieker
reviewed
Apr 1, 2025
Collaborator
fieker
left a comment
There was a problem hiding this comment.
we'll chat when in, but subfield_from_block is not called at all
thofma
commented
Apr 1, 2025
Owner
Author
|
The "linear combination" path is failing for |
fieker
reviewed
Apr 1, 2025
fieker
reviewed
Apr 1, 2025
Owner
Author
|
Error from the tests: |
fieker
reviewed
Apr 2, 2025
thofma
commented
Apr 2, 2025
fieker
reviewed
Apr 3, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
===========================================
- Coverage 76.50% 5.40% -71.10%
===========================================
Files 362 365 +3
Lines 115035 126748 +11713
===========================================
- Hits 88006 6853 -81153
- Misses 27029 119895 +92866
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.