Update show for GroupAlgebraElem with sparse rep#1688
Open
lgoettgens wants to merge 2 commits intothofma:masterfrom
Open
Update show for GroupAlgebraElem with sparse rep#1688lgoettgens wants to merge 2 commits intothofma:masterfrom
lgoettgens wants to merge 2 commits intothofma:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1688 +/- ##
==========================================
- Coverage 75.96% 75.95% -0.01%
==========================================
Files 362 362
Lines 114325 114325
==========================================
- Hits 86846 86840 -6
- Misses 27479 27485 +6
🚀 New features to boost your workflow:
|
Contributor
|
Seems sensible to me |
Contributor
|
@thofma any thoughts on this PR? |
Owner
|
Have not made up my mind yet unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me show the current issue with an example. To reproduce, you need the branch https://github.com/oscar-system/Oscar.jl/tree/lg/character-ring together with a dev'ed Hecke that includes #1685.
Thus I propose to instead of just writing the group elem as the basis elem, to do something like
e(g)as often done in the literature. With this change enabled, the problematic lines from above change to the following, which IMO is a clear readability and disambiguation improvement.