Skip to content

Towards generic roots over local fields#1599

Draft
joschmitt wants to merge 3 commits intothofma:masterfrom
joschmitt:js/roots
Draft

Towards generic roots over local fields#1599
joschmitt wants to merge 3 commits intothofma:masterfrom
joschmitt:js/roots

Conversation

@joschmitt
Copy link
Copy Markdown
Collaborator

This is my attempt of generalizing the implementation of roots over local fields in characteristic 0 to other local fields.
The main theoretical problem is that I do not know how to do a squarefree factorization in a non-perfect field of characteristic $p > 0$.

I open this pull request so that the code is not lost. I don't expect that I will continue working on this in the near future.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 10, 2024

Codecov Report

❌ Patch coverage is 15.16245% with 235 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.59%. Comparing base (25ef213) to head (589a16f).
⚠️ Report is 562 commits behind head on master.

Files with missing lines Patch % Lines
src/LocalField/roots.jl 0.00% 208 Missing ⚠️
src/LocalField/Poly.jl 30.76% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   75.78%   75.59%   -0.19%     
==========================================
  Files         362      363       +1     
  Lines      113906   114143     +237     
==========================================
- Hits        86320    86291      -29     
- Misses      27586    27852     +266     
Files with missing lines Coverage Δ
src/Misc/nmod_poly.jl 63.11% <100.00%> (+0.22%) ⬆️
src/NumFieldOrd/NfOrd/MaxOrd/Polygons.jl 89.04% <100.00%> (+0.01%) ⬆️
src/LocalField/Poly.jl 61.22% <30.76%> (-2.15%) ⬇️
src/LocalField/roots.jl 0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant