Conversation
Deploying keeptrack-space with
|
| Latest commit: |
39f1326
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa29d6da.keeptrack-space.pages.dev |
| Branch Preview URL: | https://develop.keeptrack-space.pages.dev |
Deploying keeptrack-space-embed with
|
| Latest commit: |
39f1326
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85d23631.keeptrack-space-embed.pages.dev |
| Branch Preview URL: | https://develop.keeptrack-space-embed.pages.dev |
Deploying celestrak-keeptrack with
|
| Latest commit: |
39f1326
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://537f41d6.celestrak-keeptrack.pages.dev |
| Branch Preview URL: | https://develop.celestrak-keeptrack.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR updates the satellite sensor info box plugin to improve how sensor-related geometry and “next pass” information are computed/displayed (especially for OEM satellites), while also bumping the project version to 12.1.1 and making a small configuration tweak to the short-term fences plugin.
Changes:
- Refactors OEM satellite look-angle/location handling to use
SpaceObject.rae()/SpaceObject.lla()and adds OEM-specific “Next Pass”/VMAG display logic. - Extracts next-pass string generation into a dedicated helper and adjusts edge-case messaging (e.g., beyond max range).
- Bumps version to 12.1.1 and marks STF sensors as volumetric.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/short-term-fences/short-term-fences.ts | Marks STF-created sensors as volumetric via isVolumetric: true. |
| src/plugins/sat-info-box-sensor/sat-info-box-sensor.ts | Improves sensor geometry/next-pass/VMAG handling, particularly for OEM satellites, and removes “disable sensors” gating from info visibility. |
| README.md | Updates the version badge to 12.1.1. |
| package.json | Bumps package version to 12.1.1. |
| package-lock.json | Bumps lockfile package version to 12.1.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Use SpaceObject.rae() which properly interpolates the ephemeris at the exact time | ||
| const raeResult = obj.rae(sensor, timeManagerInstance.simulationTimeObj); | ||
|
|
||
| if (raeResult) { | ||
| rae = raeResult; | ||
| isInView = sensor.isRaeInFov(rae.az, rae.el, rae.rng); | ||
| } else { | ||
| rae = { az: 0, el: 0, rng: 0 }; | ||
| isInView = false; | ||
| } |
There was a problem hiding this comment.
When obj.rae(sensor, time) returns null for an OemSatellite, this code falls back to {az:0, el:0, rng:0} and forces isInView=false. This both diverges from the PR description (“falls back to the old method if interpolation is unavailable”) and can incorrectly mark an OEM sat out-of-view / hide range/az/el even when obj.position is available. Consider falling back to the legacy eci2rae(simTime, obj.position, sensor) (or another non-interpolated look-angle computation) when raeResult is null, similar to the lla() fallback below, or update the PR description if returning N/A is intentional.
|
This pull request primarily updates the satellite sensor info box plugin to improve accuracy and robustness when displaying sensor and satellite data. It introduces more reliable methods for calculating satellite-sensor geometry, handles special cases for OEM satellites, and cleans up logic related to sensor disabling. Additionally, the version is bumped to 12.1.1, and a minor update is made to the short-term fences plugin.
Sensor Info Box Improvements:
eci2raeandeci2llawith theSpaceObject.rae()andSpaceObject.lla()methods for more accurate, time-interpolated calculations of satellite-sensor geometry and location. Falls back to the old method if interpolation is unavailable. [1] [2]calculateNextPassText_method, which now correctly handles OEM satellites (returns 'N/A (OEM)') and satellites beyond max sensor range (returns 'Beyond Max Range'). [1] [2]Logic and Cleanup:
settingsManager.isDisableSensorsin sensor info display logic, so sensor info is now shown whenever a satellite and sensor are selected, regardless of the disable setting. [1] [2]eci2rae.Version and Minor Plugin Updates:
package.jsonand the version badge inREADME.md. [1] [2]isVolumetric: trueproperty to the short-term fences plugin configuration.