Open
Conversation
…base Undo some unneeded changes and more code improvements
Open
jpechaves
changed the title
kammradt
approved these changes
Jun 16, 2023
kammradt
left a comment
kammradt
left a comment
There was a problem hiding this comment.
Hey @thiagopradi , just so you have a headsup:
I reviewed all files, and the ones that change implementation are:
(the other ones are just linter/style/really-small-refactors)
- https://github.com/thiagopradi/octopus/pull/577/files#diff-e1d5819dd27bb595e87c091f986a1ac83373a6ea6c35672342d43f64c7f1d784
- https://github.com/thiagopradi/octopus/pull/577/files#diff-3162c2d5b3f3f191c5d77fa64a532992b39058056d9fb5d95425670e2c8b9084
- https://github.com/thiagopradi/octopus/pull/577/files#diff-d16e515b7940dd390eebea1d92b0fd166fa41beabf31a3f98acf80c6747b397f
- https://github.com/thiagopradi/octopus/pull/577/files#diff-01bb2bfb627bac9391edc80ee66deb9715fc054508d1cdfe059b91f10fae2033
ylecuyer
reviewed
Jun 19, 2023
| if File.exist?(file_name) || File.symlink?(file_name) | ||
| config ||= HashWithIndifferentAccess.new(YAML.load(ERB.new(File.read(file_name)).result))[Octopus.env] | ||
| config = if File.exist?(file_name) || File.symlink?(file_name) | ||
| HashWithIndifferentAccess.new(YAML.safe_load(ERB.new(File.read(file_name)).result))[Octopus.env] |
There was a problem hiding this comment.
Would be nice to outsource it in another PR as this one isn't related to rails and would probably help to have it upstreamed faster.
Also, we should allow alisases here (or have a config for that)
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extensively rely on the
ar-octopusgem in various projects within our company. However, due to them being on an older version of Rails that lacks the matured functionalities of the new multiple database support, we are unable to leverage it. Nevertheless, this gem remains crucial for effectively managing our shards and facilitating database replica reading.To ensure compatibility with Rails version
> 6and Ruby> 3, modifications were required for our application to function correctly. Unfortunately, some of these changes may break existing applications utilizing this gem. However, I think we can collaborate to review these modifications and find a way to incorporate them into the gem, making it adaptable to everyone's use cases.