Skip to content

fixing case where delegate_hash isn't available#543

Open
pbrumm wants to merge 1 commit intothiagopradi:masterfrom
pbrumm:fix/missing_method_with_sidekiq_yaml_mailer
Open

fixing case where delegate_hash isn't available#543
pbrumm wants to merge 1 commit intothiagopradi:masterfrom
pbrumm:fix/missing_method_with_sidekiq_yaml_mailer

Conversation

@pbrumm
Copy link

@pbrumm pbrumm commented Nov 21, 2019

and this was raising an error. sidekiq + delayed_mailer and yaml

we use sidekiq's action_mailer extensions to add a delay
https://github.com/mperham/sidekiq/blob/v5.2.7/lib/sidekiq/extensions/action_mailer.rb#L33

which serializes yaml and then restores it when worker starts with
https://github.com/ruby/psych/blob/master/lib/psych/visitors/to_ruby.rb#L394
which hits your init_with and raises exception on some of the cleanup code.

so this pull fixes that by rescuing.

some inspection could also take place but the this seemed more risky.

and this was raising an error.  sidekiq + delayed_mailer and yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant