Create and drop specific shard DB.#456
Open
nenadmil wants to merge 1 commit intothiagopradi:masterfrom
Open
Conversation
Owner
|
Hi @nenadmil, Thanks for your contribution! I think it's a great use case. Can you try to extract the logic to create / drop a specific DB into a separate class and create tests for it? This is needed to merge to avoid breaking things in the future. Thiago |
Author
|
Hi, @thiagopradi Sure, I will try. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added ability to create and drop db from rake task for all shards.