dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update) by serhiy-katsyuba-intel · Pull Request #10567 · thesofproject/sof

serhiy-katsyuba-intel · 2026-02-20T16:01:51Z

Adds support for Intel USB Audio Offload Link (UAOL) DAI.

This is a revival of the old closed UAOL PR #9227.

Zephyr PR zephyrproject-rtos/zephyr#104137 is now merged.

serhiy-katsyuba-intel · 2026-02-23T11:37:35Z

SOFCI TEST

lgirdwood

LGTM

Copilot

Pull request overview

Adds Intel USB Audio Offload Link (UAOL) DAI support across the SOF/Zephyr integration and IPC4 paths, including capability reporting and node-id mapping.

Changes:

Update West manifest to a Zephyr revision that includes UAOL-related support.
Introduce the SOF_DAI_INTEL_UAOL type and wire it through DAI selection/config paths.
Add UAOL capability advertisement and UAOL stream-id → HDA link stream-id mapping for IPC4 DMA control.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
west.yml	Bumps Zephyr revision required for UAOL enablement.
src/lib/dai.c	Registers UAOL devices and maps UAOL to the Zephyr DAI type / DMA caps.
src/ipc/ipc4/dai.c	Adds UAOL handling for link config and DMA channel selection.
src/include/ipc/dai.h	Introduces `SOF_DAI_INTEL_UAOL` enum value.
src/audio/dai-zephyr.c	Adds UAOL case to Zephyr DAI configuration.
src/audio/copier/copier_dai.c	Adds UAOL stream link classes to DAI creation path.
src/audio/copier/copier.c	Routes UAOL stream link classes to `copier_dai_create()`.
src/audio/base_fw_intel.c	Advertises UAOL support/caps and maps UAOL node indices for DMA control.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/audio/copier/copier_dai.c

Copilot · 2026-03-05T16:30:28Z

src/audio/base_fw_intel.c

+	const size_t dev_count = ARRAY_SIZE(uaol_devs);
+	struct uaol_capabilities dev_cap;
+	struct ipc4_uaol_capabilities *caps = (struct ipc4_uaol_capabilities *)tuple->value;
+	size_t caps_size = offsetof(struct ipc4_uaol_capabilities, link_caps[dev_count]);


offsetof(struct ..., link_caps[dev_count]) uses a non-constant array index; this is not valid with standard offsetof/__builtin_offsetof and can fail to compile. Compute the size as sizeof(*caps) + dev_count * sizeof(caps->link_caps[0]) (or the equivalent using the element type) instead.

Suggested change

size_t caps_size = offsetof(struct ipc4_uaol_capabilities, link_caps[dev_count]);

size_t caps_size = sizeof(*caps) + dev_count * sizeof(caps->link_caps[0]);

Copilot · 2026-03-05T16:30:29Z

src/ipc/ipc4/dai.c

+	case SOF_DAI_INTEL_UAOL:
+		link_cfg.full = 0;
+		link_cfg.part.hchan = gtw_fmt->channels_count - 1;
+		link_cfg.part.dir = common_config->direction;
+		link_cfg.part.stream = common_config->host_dma_config[0]->stream_id;
+		break;


hchan is derived as channels_count - 1. If channels_count is 0, this underflows and encodes an invalid hchan value. Clamp or validate the channel count before subtracting (e.g., ensure the minimum encoded value is 0 and only subtract when channels_count > 0).

lgirdwood · 2026-03-05T20:02:14Z

@serhiy-katsyuba-intel I assuming CI will test this now ?

serhiy-katsyuba-intel · 2026-03-06T10:32:29Z

@serhiy-katsyuba-intel I assuming CI will test this now ?

Currently, CI does not have any UAOL tests enabled. Therefore, it can only test for potential regressions to existing functionality but cannot test the UAOL feature itself.

Unfortunately, the Zephyr folks want to revert the Zephyr UAOL PR because it introduced a new driver type apparently without proper architectural discussion: zephyrproject-rtos/zephyr#104976. As a result, I'll change this PR to draft status for now. :-(

Updates Zephyr to bring in UAOL support. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Fixes minor typo error. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com> Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Enables UAOL (USB Audio Offload Link) feature on Intel ADSP platforms ACE2, ACE3 and ACE4. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

serhiy-katsyuba-intel · 2026-03-13T12:16:12Z

Unfortunately, the Zephyr folks want to revert the Zephyr UAOL PR because it introduced a new driver type apparently without proper architectural discussion: zephyrproject-rtos/zephyr#104976. As a result, I'll change this PR to draft status for now. :-(

It seems that everything is now resolved with Zephyr's UAOL driver future. I am changing this PR from draft status to ready for review.

kv2019i

Looks good, only one change to the last patch.

kv2019i · 2026-03-13T13:45:47Z

src/audio/base_fw_intel.c

+		caps->link_caps[i].max_rx_fifo_size = dev_cap.max_rx_fifo_size;
+	}
+
+	tlv_value_set(tuple, type, caps_size, caps);


Not related to this PR, but reminds me we'd to add better protections against overrunning the IPC mailbox size. The overall length of the TLV is not known in these functions now, and it will be difficult to debug if we excedeed the space. Most of these are by definition ok as the structure is fixed and defined in FW.

kv2019i · 2026-03-13T13:50:31Z

app/boards/intel_adsp_ace20_lnl.conf

 CONFIG_MM_DRV_INTEL_VIRTUAL_REGION_COUNT=2
 CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=38400000
 CONFIG_SYS_CLOCK_TICKS_PER_SEC=12000
+CONFIG_UAOL=y


@serhiy-katsyuba-intel Given this is for all ACE platforms, please add this to sof/app/boards/intel_adsp/Kconfig.defconfig as:

config UAOL » default y if ACE

serhiy-katsyuba-intel requested review from RanderWang, abonislawski, dbaluta, kv2019i, lbetlej, lgirdwood, marcinszkudlinski, mmaka1, pblaszko and plbossart as code owners February 20, 2026 16:01

serhiy-katsyuba-intel force-pushed the uaol branch from c736e45 to a2901a1 Compare February 20, 2026 19:21

lgirdwood reviewed Feb 23, 2026

View reviewed changes

serhiy-katsyuba-intel force-pushed the uaol branch from a2901a1 to 31cfd45 Compare March 5, 2026 16:24

Copilot AI review requested due to automatic review settings March 5, 2026 16:24

serhiy-katsyuba-intel requested a review from tmleman as a code owner March 5, 2026 16:24

Copilot AI reviewed Mar 5, 2026

View reviewed changes

serhiy-katsyuba-intel marked this pull request as draft March 6, 2026 10:32

west.yml: update Zephyr to c8b9adaec98

7cf3d8a

Updates Zephyr to bring in UAOL support. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

serhiy-katsyuba-intel force-pushed the uaol branch from 31cfd45 to 1dad327 Compare March 13, 2026 11:34

serhiy-katsyuba-intel marked this pull request as ready for review March 13, 2026 11:40

serhiy-katsyuba-intel and others added 3 commits March 13, 2026 13:04

copier_dai: fix typo

c5148bf

Fixes minor typo error. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

dai: uaol: add support for Intel UAOL

6572036

Adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com> Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

boards: intel: enable UAOL on ACE2, ACE3 and ACE4

c27dd1c

Enables UAOL (USB Audio Offload Link) feature on Intel ADSP platforms ACE2, ACE3 and ACE4. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

serhiy-katsyuba-intel force-pushed the uaol branch from 1dad327 to c27dd1c Compare March 13, 2026 12:12

kv2019i changed the title ~~dai: uaol: add support for Intel UAOL~~ dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update) Mar 13, 2026

kv2019i requested changes Mar 13, 2026

View reviewed changes

abonislawski mentioned this pull request Mar 16, 2026

boards: ace30: Enable CONFIG_UAOL for PTL #10616

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update)#10567

dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update)#10567
serhiy-katsyuba-intel wants to merge 4 commits intothesofproject:mainfrom
serhiy-katsyuba-intel:uaol

serhiy-katsyuba-intel commented Feb 20, 2026 •

edited

Loading

Uh oh!

serhiy-katsyuba-intel commented Feb 23, 2026

Uh oh!

lgirdwood left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

lgirdwood commented Mar 5, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 6, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 13, 2026

Uh oh!

kv2019i left a comment

Uh oh!

kv2019i Mar 13, 2026

Uh oh!

kv2019i Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	size_t caps_size = offsetof(struct ipc4_uaol_capabilities, link_caps[dev_count]);
	size_t caps_size = sizeof(caps) + dev_count sizeof(caps->link_caps[0]);

Conversation

serhiy-katsyuba-intel commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-katsyuba-intel commented Feb 23, 2026

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Mar 5, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 6, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 13, 2026

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019i Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

kv2019i Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-katsyuba-intel commented Feb 20, 2026 •

edited

Loading