Modular engine#18
Draft
airblast-dev wants to merge 85 commits intomainfrom
Draft
Conversation
Honestly embaressing
* Reduce code duplication in CrosstermRenderer * Remove extra lifetime and relax constructor requirements for Line * fmt * Allow custom return value in `run` * Derive more traits for Span * Fix bad style logic * Add consistent styling support * Allow reading total time from Engine * Add span macro * Remove old comment * Add simple line-spans example * Add sides support for Block * Refactor so Line accepts more types
* change emojis * bump crate version * change description * tidy up readme --------- Co-authored-by: Amy Opas <amy.opas@proton.me>
* Require width methods for border sides and support block titles * Add width checking for widgets * unused import
* Clamp sub buffer inputs * Use saturating subtraction for line render width * Provide better panic messages on out of bounds access * Add support for right aligned block titles * Fix accidental overflows when rendering Block * Fix Line offset calculation * Fix area_is_within for Size * Add assertion and documentation for `SubBuffer::new` * Actually pass display width struct to frame context * Remove unused imports * Update example * Use title alignment and position in example
* Split Widget trait into two parts * fmt * Add docs
* Docs for `FrameContext` * Remove redundant and fault `Line::width` * Docs for `Span` * Remove duplicated code * Docs for `Title` * Remove unused method for `TitleAlignment` * Remove old test * Add Block tests and fix right positioning for titles * fmt * Add TODO note * Add LineWidth docs * Update Block title test
airblast-dev
force-pushed
the
modular-engine
branch
from
9d8e088 to
45f66ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modular design of the engine is intended to be a re-implementation of the current system with modularity.
What needs to be done for feature parity (non exhaustive):