Fixes #38335 - Add job_diff_mode to allow Ansible Check Mode in Job Templates#100
Open
bnerickson wants to merge 1 commit intotheforeman:masterfrom
Open
Fixes #38335 - Add job_diff_mode to allow Ansible Check Mode in Job Templates#100bnerickson wants to merge 1 commit intotheforeman:masterfrom
bnerickson wants to merge 1 commit intotheforeman:masterfrom
Conversation
This was referenced Mar 31, 2025
Open
Contributor
Author
|
It looks like the changes here conflict somewhat with the proposed changes in #98. I don't mind waiting for that PR to be approved/merged first and then merging those changes into this PR when the time comes. |
Merged
Member
|
I started a review of #98 and I think most comments also apply here. |
Contributor
Author
|
Rebased after changes merged in #98 I also added a missing statement in test/fixtures/action_input.json for |
nofaralfasi
approved these changes
Jul 16, 2025
Contributor
Author
|
Hi @nofaralfasi , I see this PR is approved. Is there anything pending before this PR may be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
This PR adds a separate job_diff_mode variable to the AnsibleRunner class which ultimately sets the
--diffflag in the ansible-runner command. This allows Ansible Diff Mode to be set for Jobs when the new ansible_diff_mode checkbox is selected in Ansible Job Templates (see PR theforeman/foreman_ansible#764).Implementation Consideration
None
Testing Steps
Checklists
Additional Notes
This PR is dependent on: