Compute profile - fix duplicate disks & nics

[stejskalleos]

How to test

• Go to compute profile
• Add / edit / remove storage and interfaces
  🍏 Make sure no empty duplicate disks/nics are shown in the form
  🍏 Make sure CRUD operations work

Risk

This fix edits the new_vm method, so the impact might be across the entire provisioning process.

[evgeni]

It works (tested with rubygem-foreman_kubevirt-0.5.2-1.20260226144348065801.pr190.4.gfac5f28.el9.noarch), but I am struggling to see which part of the diff is the fix. Is it the rename of the variables? The removal of <<?

[evgeni]

FTR, the bug was introduced in 4a501b4

[stejskalleos]

but I am struggling to see which part of the diff is the fix. Is it the rename of the variables? The removal of <<?

"The removal of <<" is the actual fix.
Renaming variables is a readability improvement.

[evgeni]

(FTR²: the nics are not duplicated today, as we don't add interfaces in vm_instance_defaults but it's still good to fix that too)