Override memory method to convert KubeVirt format to bytes

[archanaserver]

Fixes the host edit form displayed 'NaN MB' for KubeVirt VM memory

[archanaserver]

Those CI tests are failing seems like unrelated to this change.

[evgeni]

Ci failing is unrelated, yes.

This makes the edit of a host work for me, but now the "VMs" list on the CR throws

2026-02-12T03:06:42 [W|app|6881f772] no implicit conversion of Integer into String
2026-02-12T03:06:42 [I|app|6881f772] Backtrace for 'no implicit conversion of Integer into String' error (ActionView::Template::Error): no implicit conversion of Integer into String
 6881f772 | /usr/share/gems/gems/fog-kubevirt-1.6.0/lib/fog/kubevirt/compute/utils/unit_converter.rb:42:in `match'
 6881f772 | /usr/share/gems/gems/fog-kubevirt-1.6.0/lib/fog/kubevirt/compute/utils/unit_converter.rb:42:in `validate'
 6881f772 | /usr/share/gems/gems/fog-kubevirt-1.6.0/lib/fog/kubevirt/compute/utils/unit_converter.rb:22:in `convert'
 6881f772 | /usr/share/gems/gems/foreman_kubevirt-0.5.1/app/models/foreman_kubevirt/kubevirt.rb:542:in `convert_memory'
 6881f772 | /usr/share/gems/gems/foreman_kubevirt-0.5.1/app/models/foreman_kubevirt/kubevirt.rb:313:in `convert_memory_to_bytes'
 6881f772 | /usr/share/gems/gems/foreman_kubevirt-0.5.1/app/views/compute_resources_vms/index/_kubevirt.html.erb:15:in `block in __usr_share_gems_gems_foreman_kubevirt_______app_views_compute_resources_vms_index__kubevirt_html_erb___567930508050518905_935980'
 6881f772 | /usr/share/gems/gems/fog-core-2.6.0/lib/fog/core/collection.rb:19:in `each'
 6881f772 | /usr/share/gems/gems/fog-core-2.6.0/lib/fog/core/collection.rb:19:in `each'
 6881f772 | /usr/share/gems/gems/foreman_kubevirt-0.5.1/app/views/compute_resources_vms/index/_kubevirt.html.erb:11:in `__usr_share_gems_gems_foreman_kubevirt_______app_views_compute_resources_vms_index__kubevirt_html_erb___567930508050518905_935980'
 6881f772 | /usr/share/gems/gems/actionview-7.0.10/lib/action_view/base.rb:244:in `public_send'

[arvind4501]

Yes IT breaks on compute resource -> vms as here memory method is overriden and https://github.com/theforeman/foreman_kubevirt/blob/master/app/views/compute_resources_vms/show/_kubevirt.html.erb#L23 here with the current changes we pass the converted memory not the original one(which comes from fog). so technically converting it twice vm.memory does it once and then convert_memory_to_bytes call does it again

[archanaserver]

yeah so, convert_memory_to_bytes method trying to convert values that were already converted to bytes, and didn't handle empty strings. and with this it seems to be working.

[arvind4501]

I think if we are completely skipping convert_memory method call here than isn't it better to remove convert_memory_to_bytes method from https://github.com/theforeman/foreman_kubevirt/blob/master/app/views/compute_resources_vms/show/_kubevirt.html.erb#L23 and let @vm.memory handle conversion itself?

[evgeni]

I think no users of convert_memory_to_bytes are left, so we can drop that method alltogether.

[evgeni]

What's the reason to create a copy of the value here?
You're not modifying it and Server.memory should already be just accessing an attribute, so there seems to be no performance benefit to store it locally before accessing it?

Not blocking, just curious :)

[archanaserver]

Fair point but no strong reason. I initially kept raw_memory for readability while working through the logic and to make debugging thing easier while validating the fallback behavior. but either way it's fine for me, so I simplified it. Thanks for the catch!

[evgeni]

Tested using rubygem-foreman_kubevirt-0.5.1-1.20260212112949781331.pr186.2.g4051aff.el9.noarch.rpm, works fine on the host edit screen and in the CR VM list.

Two comments, but neither is blocking.

[evgeni]

Final round with rubygem-foreman_kubevirt-0.5.1-1.20260218045458190635.pr186.2.g7b7375f.el9.noarch.rpm, still works fine.

Thanks!