Conversation
ekohl
approved these changes
Jan 13, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Short term this is certainly an improvement, but long term I'd like to standardize on docs.theforeman.org. Comparing https://docs.theforeman.org/3.17/Provisioning_Hosts/index-foreman-el.html#Provisioning_Virtual_Machines_Kubevirt_kubevirt-provisioning and https://theforeman.org/plugins/foreman_kubevirt/0.x/index.html#4.1SettingComputeResourceTokenandX509CAvalues there is a bit of a difference and I'd love to resolve that, but have no idea how.
arvind4501
approved these changes
Jan 13, 2026
arvind4501
left a comment
arvind4501
left a comment
There was a problem hiding this comment.
Works as expected, tested with rubygem-foreman_kubevirt-0.4.1-1.20260113083258173164.pr173.5.g1cc7614.el9.noarch , thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.