automatically use system certs via truststore#1944
Open
omenos wants to merge 1 commit intotheforeman:developfrom
Open
automatically use system certs via truststore#1944omenos wants to merge 1 commit intotheforeman:developfrom
omenos wants to merge 1 commit intotheforeman:developfrom
Conversation
Author
|
Copying over my comment from ansible-collections/vmware.vmware#295 after Mike noted the behavioral change: I just did a quick check (on RHEL) and if So it's a bit of a behavior reversal, rather than:
it becomes:
Whether or not this project views that as a breaking change is not something I can define. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestsdefaults to using the certificate trust provided bycertifi, which precludes the inclusion of custom trusted certificates. Rather than needing to set theREQUESTS_CA_BUNDLEenvironment variable in every shell/config, usetruststoreto override the way certs are read and automatically use the system trust store.This will only happen transparently in environments using Python >= 3.10 and is effectively a noop in any other scenario.