Conversation
| PROJECT_XYZ_TAG=4.4.20 | ||
|
|
||
| FOREMAN_XY_TAG=3.15 | ||
| FOREMAN_XYZ_TAG=3.15.0 |
There was a problem hiding this comment.
We'll end up managing these versions across multiple of these repositories and I wonder how to properly keep this in sync. This could perhaps instead be handled at the CI level rather than here?
@ekohl Could your ideas around shared Github Actions help?
There was a problem hiding this comment.
I know Vox uses https://github.com/voxpupuli/gha-build-and-publish-a-container but must say I haven't used it myself. Perhaps something to look at? Though I also like the idea of being able to build locally.
Then I also wonder about putting it into files vs using git tags. Though changing a tag will be a really bad idea, it could be easy for visibility that it's really the same thing.
There was a problem hiding this comment.
Then I also wonder about putting it into files vs using git tags. Though changing a tag will be a really bad idea, it could be easy for visibility that it's really the same thing.
And would we git tag all the container tags for parity?
There was a problem hiding this comment.
That was my thinking, but I don't know how feasible it really is. Perhaps foreman-x.y should really be a branch and foreman-x.y.z a tag. Then we'd need x.y.z-a for bugfixes though.
Perhaps we leave out x.y.z altogether?
Makefile
Outdated
| podman tag ${IMAGE_NAME}:${IMAGE_TAG} ${IMAGE_NAME}:${FOREMAN_XYZ_TAG} | ||
|
|
||
| push: | ||
| podman push ${IMAGE_NAME}:${IMAGE_TAG} |
There was a problem hiding this comment.
This should probably push all tags, right?
|
|
||
| build: | ||
| podman build -f images/candlepin/Containerfile -t ${IMAGE_NAME}:${IMAGE_TAG} . | ||
| podman build --file images/candlepin/Containerfile --tag ${IMAGE_NAME}:${IMAGE_TAG} --build-arg TAG=${IMAGE_TAG} |
There was a problem hiding this comment.
Why not
podman pull quay.io/candlepin/candlepin:${TAG}
podman tag quay.io/candlepin/candlepin:${IMAGE_TAG} ${IMAGE_NAME}:${IMAGE_TAG}
The build feels weird given we're not actually building.
Or is that a setup to allow changes in the future?
This will re-use the Candlepin container image produced by the Candlepin project and then tags it according to the tagging rules using project and Foreman version tags.
ehelms
force-pushed
the
use-candlepin-container
branch
from
95bc2a3 to
9d98245
Compare
|
I moved the bulk of this to #4 as the how we handle tagging can be done prior to any swap of the image. |
3 participants
This will re-use the Candlepin container image produced by the Candlepin project and then tags it according to the tagging rules using project and Foreman version tags.