Skip to content

receive: poc for pooled writeable stoer #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaHoffmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

receive: poc for pooled writeable stoer #8656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/thanos/receive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,16 @@ func runReceive(
),
)

// Use pooled unmarshaling only for IngestorOnly mode where processing is synchronous.
// Router and RouterIngestor modes forward data asynchronously, which is unsafe with pooled data.
writeableStoreReg := store.RegisterWritableStoreServer(rw)
if receiveMode == receive.IngestorOnly {
writeableStoreReg = store.RegisterWritableStoreServerPooled(webHandler)
}

srv := grpcserver.New(logger, receive.NewUnRegisterer(reg), tracer, grpcLogOpts, logFilterMethods, comp, grpcProbe,
grpcserver.WithServer(store.RegisterStoreServer(rw, logger)),
grpcserver.WithServer(store.RegisterWritableStoreServer(rw)),
grpcserver.WithServer(writeableStoreReg),
grpcserver.WithServer(exemplars.RegisterExemplarsServer(exemplars.NewMultiTSDB(dbs.TSDBExemplars))),
grpcserver.WithServer(status.RegisterStatusServer(statusSrv)),
grpcserver.WithServer(info.RegisterInfoServer(infoSrv)),
Expand Down
5 changes: 5 additions & 0 deletions pkg/receive/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,11 @@ func (h *Handler) RemoteWrite(ctx context.Context, r *storepb.WriteRequest) (*st
}
}

// RemoteWritePooled implements storepb.WriteableStoreServerPooled.
func (h *Handler) RemoteWritePooled(ctx context.Context, req *storepb.PooledWriteRequest) (*storepb.WriteResponse, error) {
return h.RemoteWrite(ctx, req.WriteRequest)
}

// relabel relabels the time series labels in the remote write request.
func (h *Handler) relabel(wreq *prompb.WriteRequest) {
if len(h.options.RelabelConfigs) == 0 {
Expand Down
Loading
Loading