Fix missing closing tags in multi-page PAGE XML output#4506
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix bug in application functionality
Fix typo in bug report template: umame → uname
Feb 8, 2026
Copilot
AI
changed the title
Fix typo in bug report template: umame → uname
Fix missing closing tags in multi-page PAGE XML output
Feb 8, 2026
Member
|
@copilot, please rebase this PR to the latest code in the main branch. In addition, it would be nice to add a CI test for this issue. |
Contributor
Author
Done! The PR is now rebased on the latest main branch (the typo fix was already merged in 9c393bb). I've also added a CI test
Commit: b8e2455 |
Co-authored-by: Stefan Weil <sw@weilnetz.de>
Co-authored-by: Stefan Weil <sw@weilnetz.de>
b8e2455 to
bafb1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-page TIFF files produce malformed PAGE XML with missing
</Page>closing tags for all pages except the last, causing validation failures.Changes
GetPAGEText(): Add</Page>closing tag at end of method (line 1126)EndDocumentHandler(): Remove</Page>tag, retain only</PcGts>(line 686)PAGEXMLMultiPageClosingTagstest inunittest/baseapi_test.ccto validate proper tag closure for multi-page documentsEach page now generates a complete
<Page>...</Page>element. The document handler manages only the outer envelope, matching the pattern used inaltorenderer.cpp.Before:
After:
Testing
The new test validates:
<Page>tag</Page>tagOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.