Cmake optimization with warp2#4452
Conversation
…ble_adaptive_matcher to CLASSIFY_ENABLE_ADAPTIVE_MATCHER_OVERRIDE to avoid conflicts with the BOOL_MEMBER parameter declaration in classify.cpp
|
What is warp2? |
egorpugin
left a comment
There was a problem hiding this comment.
It is better to put any code changes outside of this CMake PR.
|
macOS CMake CI failed without these non-CMake changes. This is reason why they are in this PR. |
|
Regarding warp see https://www.warp.dev/ |
|
What is the purpose of all this? Someone says GLOBs = bad? What about the rest? |
|
Could you fix the issue? |
|
@amitdo: this PR was merged on Aug 15 This issue seems specific to the combination of macOS, CMake, and GCC; other configurations such as macOS with CMake and Clang, or Ubuntu with CMake and GCC, do not show the problem.
I do not have access to a macOS device for debugging and testing this scenario. Additionally, I noticed that the autotools-macos uses only Clang as the compiler on macOS. Perhaps we should consider skipping GCC builds in the CMake workflow for macOS as well. |
|
Seems like it if fixed. |



Usage Examples