Fix duplicated IDs in ALTO XML when multiple pages are present#4386
Merged
stweil merged 2 commits intotesseract-ocr:mainfrom May 1, 2025
Merged
Fix duplicated IDs in ALTO XML when multiple pages are present#4386stweil merged 2 commits intotesseract-ocr:mainfrom
stweil merged 2 commits intotesseract-ocr:mainfrom
Conversation
Member
|
Thanks for the fix. I just wonder whether we should try to keep the current IDs for the most common use case where only a single page is processed. This could be achieved for example by
|
Contributor
Author
|
Thanks for your suggestion @stweil! I added a function Disclosure: I haven't written CPP before, so pls check for rookie mistakes :) |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of duplicated IDs in ALTO XML output when processing multiple pages by incorporating the page number into the generated IDs.
- Introduces a new helper function (GetID) to generate IDs based on a prefix, page number, and counter.
- Updates ID assignments for elements such as Illustration, GraphicalElement, ComposedBlock, TextBlock, TextLine, and String to ensure uniqueness.
Comments suppressed due to low confidence (1)
src/api/altorenderer.cpp:54
- [nitpick] Consider renaming GetID to 'GenerateUniqueID' to more clearly reflect its role in creating unique IDs across pages.
static std::string GetID(char const * prefix, int page_number, int counter) {
stweil
reviewed
Apr 28, 2025
…nt pge This will ensure, validated ALTO XML output is generated while keeping IDs for the first page consistent as before.
Member
|
Thank you again! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tesseract on a list of images and validating the alto output using the schema (https://www.loc.gov/alto/v3/alto-3-0.xsd), I had the following error:
Digging into the type of
BlockTypeID, I found axsd:IDrestriction - meaning theBlockTypeIDcan only exist once in the whole document / is unique per document.I incorporated the current
page_numberinto the IDs thus resolving the issue.