open fun in open class Router

[Starksoft]

I'm using custom Router implementation and use internal logger. Router is open class, but have final methods, I need them to be open (custom logger & custom RouterImpl)

[AlexeyKorshun]

It is not good idea. But it is a good point. @terrakok maybe we should create an interface for router?

[Starksoft]

It is not good idea. But it is a good point. @terrakok maybe we should create an interface for router?

I really don't understand, why it is "bad" idea.

If I want to extend the functionality of this Router all methods must be non-final.
In this case, the developer takes responsibility for the incorrect behavior of the library, after his intervention.

In my case I incapsulate authorization checks in RouterWrapper, and check if screen can be opened without auth or open login screen otherwise

[terrakok]

For your case more suitable approach is wrap router with your logic which will delegate calls to inner router.
For easy swap Cicerone router to your Business router with DI it is reasonable to extract interface from router