feat: add support of xdefi wallet#134
Open
hinterlist wants to merge 1 commit intoterra-money:mainfrom
Open
Conversation
hinterlist
force-pushed
the
feat/upgrade-wallet-provider
branch
from
950e720 to
b918e56
Compare
alecande11
suggested changes
Apr 13, 2022
|
|
||
| await login({ | ||
| user: { | ||
| address: result.address, |
Contributor
There was a problem hiding this comment.
@dimitrykislichenko it doesn't work for me,
with the Prioritise XDEFI wallet option enabled i receive an error in this line:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'address')
at onClickXDEFIExtension (index.tsx:65:1)
without the prioritise option it doesn't detect the wallet
Contributor
There was a problem hiding this comment.
sorry I made the comment some time ago, now it detect the extension without the prioritise option.
But it is still throwing the Cannot read properties of undefined (reading 'address') error
There was a problem hiding this comment.
Manage your work-related matters with patience.
Sometimes the problem is not the program and the solution is waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of XDEFI Wallet
I'd recommend to migrate to wallet-provider which out of the box allow to identify installed and recommended wallets and better handle targeted connection. With current approach when user will try to connect to Terra Station and in case if user has XDEFI Wallet and Terra Station, both will popup.