Return empty options if master root is null#264
Open
zonky2 wants to merge 1 commit intoterminal42:mainfrom
Open
Return empty options if master root is null#264zonky2 wants to merge 1 commit intoterminal42:mainfrom
zonky2 wants to merge 1 commit intoterminal42:mainfrom
Conversation
Member
|
Can you explain why that would be necessary? How can you not have a fallback page on a website you're currently working on? |
Author
|
Phew, that was a month ago – I'll have to look up which project that happened in... But if it weren't possible, I wouldn't have made the mistake of |
Member
|
I understand that, but addint a fix for something that might be a configuration issue in your setup isn't really worth having and needing maintenance etc... or we might want to throw an exception so users becore aware of the configuration issue. But all of that we can only know with a description (would have been good to have one in the first place 😉) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.