feat: pass answers to validator function#382
Open
DesignByOnyx wants to merge 1 commit intoterkelg:masterfrom
Open
feat: pass answers to validator function#382DesignByOnyx wants to merge 1 commit intoterkelg:masterfrom
DesignByOnyx wants to merge 1 commit intoterkelg:masterfrom
Conversation
Author
|
I needed this again today and prefer not to use my fork. I have time, availability, and eagerness to implement this. I will write tests and ensure there are no breaking changes. Any feedback from the team would be great... even if it's in the form of "we don't have time to review this, and it probably wont get merged" would help. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #273
I don't consider this done yet, but I wanted to go ahead and take a stab at this and get some feedback. Tasks still remaining:
This is not my favortie implementation, but it's the best I could come up with short of a refactor. The crux of the problems is we need to pass the answers to all elements as they are constructed. In an ideal world the question and answers would be passed as two separate arguments to the element constructors. I'm glad to make that change, though it will touch a lot more files and lines of code.