Fix flaky test: TestTooManyCancelRequests/CancelAllWorkflowsAtOnce#8860
Open
Fix flaky test: TestTooManyCancelRequests/CancelAllWorkflowsAtOnce#8860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed race condition in
TestClientMiscTestSuite/TestTooManyCancelRequests/CancelAllWorkflowsAtOnceby reordering test operations to wait for workflow completion before checking history.Why?
The test was failing intermittently in CI with:
The test was checking workflow history immediately after starting the workflow, before ensuring the workflow task had been executed by a worker. This created a race condition where the test could check history before all events were persisted (WorkflowTaskStarted and WorkflowTaskFailed events).
The fix reorders operations to call
run.Get()(which waits for workflow completion) beforeWaitForHistoryEvents(). This ensures proper synchronization and that all history events are persisted before verification.This follows the same pattern used in
TestTooManyPendingSignalsin the same file.How did you test it?