Fix: Subscription fails on AWS IoT Core broker #876
Fix: Subscription fails on AWS IoT Core broker #876AlvaroVega merged 4 commits intotelefonicaid:masterfrom
Conversation
|
Maybe this fix #633 could help to reduce the number of topics subscribed by iotagent. |
|
@AlvaroVega |
| @@ -1 +1,2 @@ | |||
| - Fix: bad json measures are reported as 500 Error instead of 400 (#863) | |||
| - Fix: Subscription fails on AWS IoT Core broker (#875) | |||
There was a problem hiding this comment.
CNR update should include upgrade dependence version mqtt from 4.X to 5.X
| keepalive: mqttConfig.keepalive ? parseInt(mqttConfig.keepalive) : 60, | ||
| connectTimeout: 60 * 60 * 1000 | ||
| connectTimeout: 60 * 60 * 1000, | ||
| subscribeBatchSize: 8 |
There was a problem hiding this comment.
According with doc: https://www.npmjs.com/package/mqtt
subscribeBatchSize : optional number Maximum number of topics per SUBSCRIBE packet. When the number of topics to subscribe exceeds this value, the client will automatically split them into multiple SUBSCRIBE packets of this size.
but what is the default value used by subscribeBatchSize if none is provided ? Not sure if this new conf should be added into mqttConfig.
I guess default value for subscribeBatchSize is null, so this should be the default value used and then subscribeBatchSize should be added to mqttConfig (like keepalive or others conf options) to be modified by local configuration (i.e. docker env var).
|
@Sheile thanks for your contribution!
Actually, this is not needed, as IOTA-UL is now in deprecated state. |
Sheile
force-pushed
the
task/support-aws-iot-core
branch
from
387f20f to
4c3b914
Compare
Sheile
force-pushed
the
task/support-aws-iot-core
branch
from
4c3b914 to
b18cec2
Compare
AlvaroVega
left a comment
AlvaroVega
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution @Sheile !
LGTM
3 participants
Issue: #875
After merged it. I'll create same PR against to telefonicaid/iotagent-ul.