Added option to turn shared subscription off or change the group identifier #754
Added option to turn shared subscription off or change the group identifier #754fbuedding wants to merge 2 commits intotelefonicaid:masterfrom
Conversation
| if ( | ||
| amqpConfig.options && amqpConfig.options.durable | ||
| ) { | ||
| if (amqpConfig.options && amqpConfig.options.durable) { |
There was a problem hiding this comment.
the code of this file was tainted, but no really changes?
There was a problem hiding this comment.
This is due linting and/or prettier. I just ran the scripts defined in the package.json
| function generateCommandExecution(apiKey, device, attribute) { | ||
| let payload = {}; | ||
| let command = device && device.commands.find((att) => att.name === attribute.name); | ||
| const command = device && device.commands.find((att) => att.name === attribute.name); |
There was a problem hiding this comment.
command could be modified in line 99
|
Maybe new configuration option about disable shared subscription should be also added an explained into: https://github.com/telefonicaid/iotagent-json/blob/master/docs/installationguide.md#mqtt-configuration |
|
As described in the twin PR I only really changed the following files:
|
| topics.push(constants.MQTT_SHARE_SUBSCRIPTION_GROUP + '/+/+/' + constants.MEASURES_SUFIX + '/+'); | ||
| topics.push( | ||
| constants.MQTT_SHARE_SUBSCRIPTION_GROUP + | ||
| if (config.getConfig().mqtt.sharedSubscriptionsDisabled === true) { |
There was a problem hiding this comment.
|
Honestly no idea why the test is failing or timing out, here are my test results (16.x): 129 passing (13s)
(18.x) 129 passing (13s)
|
Twin PR, same changes.