Add SSRF protection to HTTP resolver by blocking private/internal IPs#9937
Open
ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
Open
Add SSRF protection to HTTP resolver by blocking private/internal IPs#9937ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
Conversation
Resolves tektoncd#9602. The HTTP resolver now blocks requests to private, loopback, link-local, and CGNAT IP addresses by default to prevent SSRF attacks. A new block-private-ips ConfigMap toggle (default true) allows admins to opt out for legitimate internal use. Signed-off-by: ab-ghosh <abghosh@redhat.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #9602
This PR adds defense-in-depth IP filtering to
makeHttpClient():http.Transportwith aDialContextthat resolves the target hostname and rejects connections to private, loopback, link-local, CGNAT, and unspecified IP addressesblock-private-ipsconfig key inhttp-resolver-configConfigMap, defaulting to"true". Administrators who need the resolver to reach internal registries can set it to"false"/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes