Fix Uncurried Fragment module signature#297
Open
illusionalsagacity wants to merge 3 commits intoteamwalnut:masterfrom
Open
Fix Uncurried Fragment module signature#297illusionalsagacity wants to merge 3 commits intoteamwalnut:masterfrom
illusionalsagacity wants to merge 3 commits intoteamwalnut:masterfrom
Conversation
src/ppx/output_module.ml
Outdated
Comment on lines
1029
to
1033
| wrap_as_uncurried_fn [%stri let parse (value : Raw.t) = [%e parse_fn]]; | ||
| wrap_as_uncurried_fn | ||
| [%stri | ||
| let parse = (fun value -> [%e parse_fn] : Raw.t -> [%t type_name])]; | ||
| wrap_as_uncurried_fn | ||
| [%stri | ||
| let serialize = | ||
| (fun value -> [%e serialize_fn] : [%t type_name] -> Raw.t)]; |
Author
There was a problem hiding this comment.
I've fiddled with this a few times and all the options seem to generate a lot of changes in the printed output.
generate_operation_implementation doesn't include any type annotations here, would that be preferable for this as well?
illusionalsagacity
force-pushed
the
fix-uncurried-fragment-signature
branch
2 times, most recently
from
1a08f56 to
24dc054
Compare
resolves teamwalnut#296 the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something? re-run tests
illusionalsagacity
force-pushed
the
fix-uncurried-fragment-signature
branch
from
24dc054 to
a27bf33
Compare
Author
|
Are there other test projects I can try this build against? |
illusionalsagacity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #296
the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended
I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something?