Skip to content

Allow custom ranges given pdftk handles them #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AngelAlvarado wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow custom ranges given pdftk handles them #51

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
314833b
Allow custom ranges given pdftk handles them
AngelAlvarado Oct 22, 2019
d9a070d
Ignore 'Warning: no info dictionary' in data_dump
Jun 30, 2020
9f6531e
Merge pull request #2 from 1deg/enhancement-tg-4105
Jun 30, 2020
4e4d48c
Change '==' comparison for warning message to '.include?'
Jul 2, 2020
028fe99
Merge pull request #3 from 1deg/enhancement-tg-4105
Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions lib/active_pdftk/call.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ def pdftk(dsl_statements = {})
end
stdin.close
@output.puts stdout.read if @output && !@output.is_a?(String)
raise(CommandError, {:stderr => @error, :cmd => cmd}) unless (@error = stderr.read).empty?
# We ignore 'no info dictionary' warning since it doesn't affect the integrity of the PDF
# and handling this warning as an error prevents us from accessing the other metadata
raise(CommandError, {:stderr => @error, :cmd => cmd, :stdout => stdout, :output => @output}) unless
((@error = stderr.read).empty? || @error.include?("Warning: no info dictionary found"))
end
if dsl_statements[:operation].to_s.match(/burst|unpack_files/) && dsl_statements[:output].nil?
Dir.tmpdir
Expand Down Expand Up @@ -456,14 +459,20 @@ def build_options(*args)
#
def build_range_option(range_args)
range = ""
if range_args[:pdf] && !@input_file_map.nil?
raise(MissingInput, {:input => range_args[:pdf]}) unless @input_file_map.has_key?(range_args[:pdf])
range += @input_file_map[range_args[:pdf]]
end
range += range_args[:start].to_s if range_args[:start]
if range_args[:end]
range += "1" unless range_args[:start]
range += "-#{range_args[:end]}"
if range_args[:custom_range]
#@todo validate range and account for multiple PDFs
#@todo add tests to this
range += range_args[:custom_range]
else
if range_args[:pdf] && !@input_file_map.nil?
raise(MissingInput, {:input => range_args[:pdf]}) unless @input_file_map.has_key?(range_args[:pdf])
range += @input_file_map[range_args[:pdf]]
end
range += range_args[:start].to_s if range_args[:start]
if range_args[:end]
range += "1" unless range_args[:start]
range += "-#{range_args[:end]}"
end
end
range += range_args[:pages] if range_args[:pages]
range += range_args[:orientation] if range_args[:orientation]
Expand Down