Open
Conversation
Member
🃏 4 Cards ChangedDetails: 4 new ➕ New card: SM245.tsFile: data/Sun%20&%20Moon/SM%20Black%20Star%20Promos/SM245.ts ➕ New card: SM246.tsFile: data/Sun%20&%20Moon/SM%20Black%20Star%20Promos/SM246.ts ➕ New card: SM247.tsFile: data/Sun%20&%20Moon/SM%20Black%20Star%20Promos/SM247.ts ➕ New card: SM248.tsFile: data/Sun%20&%20Moon/SM%20Black%20Star%20Promos/SM248.ts |
thomas-bassett
requested changes
Apr 26, 2026
Contributor
thomas-bassett
left a comment
thomas-bassett
left a comment
There was a problem hiding this comment.
Please add variants or in this case variant using the detailed_variant format please
Contributor
Author
Hi @thomas-bassett , is there a standard format for variants when there is no information? |
Contributor
|
It defaults to normal=true but ideally we don't want that for new additions |
…/cards-database into feat/sun-moon-promos
Contributor
Author
I did a new search and found the variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added the missing SM Black Star Promos cards from
SM245toSM248.Details
Added data for:
SM245MismagiusSM246Sabrina & BrycenSM247Reshiram & Charizard GXSM248Pikachu & Zekrom GXAlso updated the official card count for SM Black Star Promos to
248.Card information was completed using Limitless TCG as reference, including multilingual names/text where available.