data: declare reverse holo variants for SV03.5 set#1395
data: declare reverse holo variants for SV03.5 set#1395thomas-bassett merged 1 commit intotcgdex:masterfrom
Conversation
🃏 153 Cards ChangedDetails: 153 modified Bulbasaur (sv03.5-001) (found using en)
File: [data/Scarlet & Violet/151/001.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/001.ts) Ivysaur (sv03.5-002) (found using en)
File: [data/Scarlet & Violet/151/002.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/002.ts) Charmander (sv03.5-004) (found using en)
File: [data/Scarlet & Violet/151/004.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/004.ts) Charmeleon (sv03.5-005) (found using en)
File: [data/Scarlet & Violet/151/005.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/005.ts) Squirtle (sv03.5-007) (found using en)
File: [data/Scarlet & Violet/151/007.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/007.ts) Wartortle (sv03.5-008) (found using en)
File: [data/Scarlet & Violet/151/008.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/008.ts) Caterpie (sv03.5-010) (found using en)
File: [data/Scarlet & Violet/151/010.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/010.ts) Metapod (sv03.5-011) (found using en)
File: [data/Scarlet & Violet/151/011.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/011.ts) Butterfree (sv03.5-012) (found using en)
File: [data/Scarlet & Violet/151/012.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/012.ts) Weedle (sv03.5-013) (found using en)
File: [data/Scarlet & Violet/151/013.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/013.ts) Kakuna (sv03.5-014) (found using en)
File: [data/Scarlet & Violet/151/014.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/014.ts) Beedrill (sv03.5-015) (found using en)
File: [data/Scarlet & Violet/151/015.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/015.ts) Pidgey (sv03.5-016) (found using en)
File: [data/Scarlet & Violet/151/016.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/016.ts) Pidgeotto (sv03.5-017) (found using en)
File: [data/Scarlet & Violet/151/017.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/017.ts) Pidgeot (sv03.5-018) (found using en)
File: [data/Scarlet & Violet/151/018.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/018.ts) Rattata (sv03.5-019) (found using en)
File: [data/Scarlet & Violet/151/019.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/019.ts) Raticate (sv03.5-020) (found using en)
File: [data/Scarlet & Violet/151/020.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/020.ts) Spearow (sv03.5-021) (found using en)
File: [data/Scarlet & Violet/151/021.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/021.ts) Fearow (sv03.5-022) (found using en)
File: [data/Scarlet & Violet/151/022.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/022.ts) Ekans (sv03.5-023) (found using en)
File: [data/Scarlet & Violet/151/023.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/023.ts) Pikachu (sv03.5-025) (found using en)
File: [data/Scarlet & Violet/151/025.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/025.ts) Raichu (sv03.5-026) (found using en)
File: [data/Scarlet & Violet/151/026.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/026.ts) Sandshrew (sv03.5-027) (found using en)
File: [data/Scarlet & Violet/151/027.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/027.ts) Sandslash (sv03.5-028) (found using en)
File: [data/Scarlet & Violet/151/028.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/028.ts) Nidoran♀ (sv03.5-029) (found using en)
File: [data/Scarlet & Violet/151/029.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/029.ts) Nidorina (sv03.5-030) (found using en)
File: [data/Scarlet & Violet/151/030.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/030.ts) Nidoqueen (sv03.5-031) (found using en)
File: [data/Scarlet & Violet/151/031.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/031.ts) Nidoran♂ (sv03.5-032) (found using en)
File: [data/Scarlet & Violet/151/032.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/032.ts) Nidorino (sv03.5-033) (found using en)
File: [data/Scarlet & Violet/151/033.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/033.ts) Nidoking (sv03.5-034) (found using en)
File: [data/Scarlet & Violet/151/034.ts](https://github.com/tcgdex/cards-database/blob/856bebad519c5d5ee76a1f10fecf4dff935767bb/data/Scarlet & Violet/151/034.ts)
|
thomas-bassett
left a comment
thomas-bassett
left a comment
There was a problem hiding this comment.
Hey @mathieu-gilloots thanks for the pr. We are going through and updating these manually at the moment. Would you mind please using the new variants_detailed format instead of the boolean?
Common, Uncommon and Rare cards in the Scarlet & Violet 151 set all have
a Reverse Holofoil print available (visible on Cardmarket, TCGplayer,
and Bulbapedia) but the source files only declared the variants they
explicitly disabled. The API thus returned `reverse: false` for all 153
cards in scope, hiding the existence of these prints to consumers.
This commit makes the variants explicit:
- Common (66 cards): { normal: true, reverse: true }
- Uncommon (62 cards): { normal: true, reverse: true }
- Rare (25 cards): { normal: false, holo: true, reverse: true }
(Rares in SV-era are holo by default, no non-holo print exists)
Other rarities (Ultra/Double/Illustration/Special illustration/Hyper)
left untouched, since they only have their special print.
mathieu-gilloots
force-pushed
the
fix/151-reverse-variants
branch
from
b9f4237 to
6c39762
Compare
|
@thomas-bassett like that ? |
thomas-bassett
left a comment
thomas-bassett
left a comment
There was a problem hiding this comment.
That will do nicely will save us a little bit of work
3 participants
Common, Uncommon and Rare cards in the Scarlet & Violet 151 set all have a Reverse Holofoil print available (visible on Cardmarket, TCGplayer, and Bulbapedia) but the source files only declared the variants they explicitly disabled. The API thus returned
reverse: falsefor all 153 cards in scope, hiding the existence of these prints to consumers.This commit makes the variants explicit:
Other rarities (Ultra/Double/Illustration/Special illustration/Hyper) left untouched, since they only have their special print.
Details
151 cards have their reverse variant.