Add possibility to search a card with name in all languages at the same time#1181
Open
kvacquier wants to merge 1 commit intotcgdex:masterfrom
Open
Add possibility to search a card with name in all languages at the same time#1181kvacquier wants to merge 1 commit intotcgdex:masterfrom
kvacquier wants to merge 1 commit intotcgdex:masterfrom
Conversation
Contributor
|
Im not 100% sure this is an endpoint we would likly want, as it kind of breaks the search logic i.e the soultion i think is in another pr that i have open that links each card and returns all the endpoints for the differnt langagues of the same card. this is possibly also a candiate for v3 of the graphql endpoint to allow you to filter by multiple langs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
anyNamequery parameter to theGET /v2/{lang}/cardsendpointDetails
The existing
namefilter only searches card names in the requested language. This makes it impossible to find a card if you only know its name in another language (e.g. searchingname=Dracaufeuon/v2/en/cardsreturns nothing, even though Charizard exists).The new
anyNameparameter searches across all 18 language card lists and returns the matching cards in the requested language:It supports the same operator prefixes as other filters (
like:,eq:,not:,neq:, etc.) and can be combined with any other query parameter (set,rarity,hp, etc.).Note: since this repository is card data only, you may want to open the PR against the server repo instead if that's tracked separately. Let me know.