fix: resolve deprecation warnings, typo, and xpassed tests#1037
fix: resolve deprecation warnings, typo, and xpassed tests#1037reachsridhard wants to merge 1 commit intotaverntesting:masterfrom
Conversation
- Remove deprecated ctx=ast.Load() from ast.Dict() calls in test_marks.py (Python 3.13+) - Fix typo 'faull' -> 'full' in MQTT client docstring - Remove @pytest.mark.xfail from TestPykwalifyExtension (tests now passing)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR contains three independent maintenance updates: a typo correction in an MQTT client TODO comment, removal of an xfail marker from pykwalify validation tests, and removal of deprecated ctx arguments from ast.Dict constructor calls in unit tests. ChangesMaintenance and Test Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gh pr create --title "fix: resolve deprecation warnings, typo, and xpassed tests" --body-file - <<'EOF'
Summary
This PR addresses three minor issues in the codebase: Python 3.13+ deprecation warnings, a typo in documentation, and tests marked as xfail that are now passing.
Changes Made
1. Fix Python 3.13+ Deprecation Warnings (tests/unit/test_marks.py)
ctxparameter in Python 3.13+ctx=ast.Load()from 4ast.Dict()constructor calls2. Fix Typo in MQTT Client (tavern/_plugins/mqtt/client.py)
3. Fix xpassed Tests (tests/unit/test_helpers.py)
@pytest.mark.xfailbut tests are now passing@pytest.mark.xfaildecoratorTesting
Checklist
EOF
Summary by CodeRabbit
Release Notes
Tests
Documentation