Skip to content

fix: handle ValueError from formatter.parse() on malformed format strings (#733) #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelboulton merged 5 commits into from
May 10, 2026
Merged

fix: handle ValueError from formatter.parse() on malformed format strings (#733) #1030

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
385add0
fix: handle ValueError from formatter.parse() on malformed format str…
devimano2011 Apr 28, 2026
5f7f2c3
fix: also guard formatter.parse() in _attempt_find_include() against …
devimano2011 Apr 29, 2026
b5409e4
refactor: extract _safe_parse_format_string() helper used by both cal…
devimano2011 Apr 29, 2026
cd8dda3
fix: raise BadSchemaError on unmatched braces instead of silently ret…
devimano2011 May 2, 2026
a75dd7e
Merge branch 'master' into fix/733-formatter-parse-value-error
michaelboulton May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tavern/_core/dict_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ def _check_and_format_values(to_format: str, box_vars: Box) -> str:
Formatted string with variables replaced by their values
"""
formatter = string.Formatter()
would_format = formatter.parse(to_format)
try:
would_format = list(formatter.parse(to_format))
except ValueError as e:
raise exceptions.BadSchemaError(
f"Format string '{to_format}' contains invalid syntax (unmatched '{{' or '}}')."
" Escape literal braces as '{{{{' and '}}}}' if they are not format placeholders."
) from e

for _, field_name, _, _ in would_format:
if field_name is None:
Expand Down Expand Up @@ -92,7 +98,13 @@ def _attempt_find_include(to_format: str, box_vars: box.Box) -> str | None:
The retrieved value after applying any conversion, or None if not found
"""
formatter = string.Formatter()
would_format = list(formatter.parse(to_format))
try:
would_format = list(formatter.parse(to_format))
except ValueError as e:
raise exceptions.BadSchemaError(
f"Format string '{to_format}' contains invalid syntax (unmatched '{{' or '}}')."
" Escape literal braces as '{{{{' and '}}}}' if they are not format placeholders."
) from e

yaml_tag = ForceIncludeToken.yaml_tag

Expand Down
Loading