Vendor RatEye into monorepo and update name-scan marker#2
Conversation
Bring RatEye v4.0.1 sources under RatEye/ and wire the app via ProjectReference so scan/marker changes land with the app. Align RatStash and System.Drawing.Common with the app major versions, disable package publish on the vendored project, and document the layout.
Convert provided WebP (28x28) to PNG for System.Drawing, embed it in RatEye resources, set MarkerItemScale to 16/28, and ship a Data copy.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (135)
📝 WalkthroughWalkthroughChangesRatEye is vendored as an in-repository project with configurable OCR, template matching, inventory detection, icon caching, and image utilities. RatScanner adds GraphQL schema caching, update delivery, scan-result presentation models, session history, redesigned application pages, theme styling, tests, and updated build/development tooling. RatEye scanning foundation
RatScanner application flow
Repository support
Estimated code review effort: 5 (Critical) | ~120 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
codeant-ai
Bot
added
the
size:XXL
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (this incremental pass)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 3db3563)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3db3563)Status: 11 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Files Reviewed (this incremental pass)
Fix these issues in Kilo Cloud Previous review (commit 9b68001)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Files Reviewed (4 files)
Reviewed by step-3.7-flash · Input: 142.2K · Output: 35.7K · Cached: 2.2M |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| protected override void OnInitialized() { RefreshResult(); if (History.Selected is not null) { _result = History.Selected; History.Selected = null; } if (!MenuVM.LastItemScan.IsSeed) AddRecent(MenuVM.LastItemScan); MenuVM.PropertyChanged += OnResultChanged; } | ||
| private void RefreshResult() => _result = MenuVM.LastItemScan.IsSeed ? null : ScanResultAdapter.Map(MenuVM); | ||
| private async void OnResultChanged(object? sender, PropertyChangedEventArgs e) => await InvokeAsync(() => { RefreshResult(); if (e.PropertyName == nameof(RatScannerMain.ItemScans) && !MenuVM.LastItemScan.IsSeed) AddRecent(MenuVM.LastItemScan); StateHasChanged(); }); |
There was a problem hiding this comment.
WARNING: OnResultChanged never calls AddRecent because MenuVM forwards property changes with e.PropertyName = null
When RatScannerMain.ItemScans changes, MenuVM.ModelPropertyChanged calls OnPropertyChanged() with no argument, which raises PropertyChanged with e.PropertyName = null. OnResultChanged then checks e.PropertyName == nameof(RatScannerMain.ItemScans), which is always false because e.PropertyName is null. As a result, AddRecent is never called and the recent scans list stays empty.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
2 participants
User description
Summary
RatEye/and switch RatScanner from the NuGet package to an in-repoProjectReference, so scan/marker/OCR changes ship with the app in one PR.RatStash6.0.0,System.Drawing.Common8.0.7), disable NuGet packaging on the vendored project, and document the layout inRatEye/VENDOR.mdandAGENTS.md.RatScanner/Data/icon_search.pngoverride) and setMarkerItemScaleto16/28.Test plan
dotnet restore RatScanner.slndotnet build RatScanner.sln(Debug) — 0 errorsdotnet build RatScanner.sln -c Release— 0 errorsCodeAnt-AI Description
Ship RatEye with the app and update scan detection to the new marker
What Changed
Impact
✅ Fewer broken scans after UI changes✅ More reliable name and item detection✅ Cleaner marker matching on current inspection windows💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.