Feat/ws/stmt2

[qevolg]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[Copilot]

Pull request overview

This PR adjusts the taos-ws-py Rust extension’s upstream Rust connector dependency to a feat/stmt2 branch (presumably to enable/validate stmt2 functionality) and includes minor cleanup in the SQLAlchemy test file.

Changes:

• Update taos-ws-py to pull taos from taos-connector-rust branch feat/stmt2 and refresh the lockfile sources.
• Remove a few stale commented lines in tests/test_sqlalchemy.py.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/test_sqlalchemy.py	Removes commented-out lines; touched the __main__ section output text.
taos-ws-py/Cargo.toml	Switches taos dependency from main to feat/stmt2 branch for unix/windows targets.
taos-ws-py/Cargo.lock	Updates git source hashes to the feat/stmt2 branch commit for taos-related crates.

Comments suppressed due to low confidence (1)

taos-ws-py/Cargo.toml:40

• This switches the taos git dependency to track a named branch (feat/stmt2). Branch-based git dependencies can change over time and make builds harder to reproduce/debug. Prefer pinning to an immutable git rev (or a tag) in Cargo.toml, and update Cargo.lock accordingly if needed.

[target.'cfg(windows)'.dependencies]
taos = { git = "https://github.com/taosdata/taos-connector-rust.git", branch = "feat/stmt2", default-features = false, version = "0.12.3", features = [
	"optin",
	"ws-rustls",
	"ws-rustls-aws-lc-crypto-provider",
] }
[target.'cfg(unix)'.dependencies]
taos = { git = "https://github.com/taosdata/taos-connector-rust.git", branch = "feat/stmt2", default-features = false, version = "0.12.3", features = [
	"optin",
	"ws-rustls",
	"ws-rustls-ring-crypto-provider",
] }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The message printed under __main__ contains a typo: sqlalcemy should be sqlalchemy for clarity (this shows up in test output and logs).

Suggested change

	print("hello, test sqlalcemy db api. do nothing\n")
	print("hello, test sqlalchemy db api. do nothing\n")

[gemini-code-assist]

Code Review

This pull request updates the project's Rust dependencies to point to the 'feat/stmt2' branch and cleans up the SQLAlchemy test suite by removing commented-out code. Feedback was provided regarding the risk of using a feature branch as a dependency in 'Cargo.toml', as it may lead to build failures if the branch is modified or deleted; using a specific commit hash or a stable branch is recommended instead.

[gemini-code-assist]

Using a feature branch (feat/stmt2) as a dependency in Cargo.toml is risky for code that might be merged into a stable branch. If the feature branch is deleted or rebased, it can break future builds. It is generally better to point to a specific commit hash or a stable branch like main once the feature is integrated.

[gemini-code-assist]

Using a feature branch (feat/stmt2) as a dependency in Cargo.toml is risky for code that might be merged into a stable branch. If the feature branch is deleted or rebased, it can break future builds. It is generally better to point to a specific commit hash or a stable branch like main once the feature is integrated.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (68c84f8) to head (7016895).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          24       24           
  Lines        3717     3717           
=======================================
  Hits         3048     3048           
  Misses        669      669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

taos-ws-py/Cargo.toml:40

• taos dependency is switched to a moving git branch (branch = "feat/stmt2"). Even though Cargo.lock currently pins a commit, the branch reference can change over time and lead to non-reproducible builds when the lockfile is regenerated or when downstream tooling ignores the lock. Prefer pinning to an immutable rev (or a released tag/version on crates.io) for both unix and windows targets, and update the lockfile accordingly.

[target.'cfg(windows)'.dependencies]
taos = { git = "https://github.com/taosdata/taos-connector-rust.git", branch = "feat/stmt2", default-features = false, version = "0.12.3", features = [
	"optin",
	"ws-rustls",
	"ws-rustls-aws-lc-crypto-provider",
] }
[target.'cfg(unix)'.dependencies]
taos = { git = "https://github.com/taosdata/taos-connector-rust.git", branch = "feat/stmt2", default-features = false, version = "0.12.3", features = [
	"optin",
	"ws-rustls",
	"ws-rustls-ring-crypto-provider",
] }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.