Fix inflation preventing placement of items matching bin dimensions#67
Open
n41l wants to merge 2 commits intotamasmeszaros:masterfrom
Open
Fix inflation preventing placement of items matching bin dimensions#67n41l wants to merge 2 commits intotamasmeszaros:masterfrom
n41l wants to merge 2 commits intotamasmeszaros:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When min_obj_distance > 0, items are inflated before packing but the bin was not, causing items whose dimensions match the bin to fail placement. Now the bin is inflated/deflated alongside items so inflation only affects item-to-item spacing, not item-to-bin-edge spacing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_obj_distance > 0, items are inflated before packing but the bin was not, causing items whose dimensions match (or nearly match) the bin to fail placementinflateBinoverloads for_Box,_Circle, and arbitrary polygon bin typesTest plan
min_obj_distance > 0min_obj_distance > 0🤖 Generated with Claude Code