chore(ci): matrix test on py 3.13 and 3.14#999
chore(ci): matrix test on py 3.13 and 3.14#999Kevin James (TheKevJames) wants to merge 1 commit intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration pipeline by integrating support for newer Python versions, specifically 3.13 and 3.14. This update ensures that the project's builds and tests are run against the latest stable Python releases, improving compatibility and future-proofing the CI environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Python 3.13 and 3.14 to the CI test matrix. While testing against upcoming Python versions is a good practice, the specified Docker image tags (python:3.13.12 and python:3.14.3) are invalid because these specific versions have not been released and the tags do not exist on Docker Hub. This will cause the CI pipeline to fail. My review includes suggestions to use a valid pre-release tag for Python 3.13 and to remove the changes related to Python 3.14 for now, as no official images are available for it yet. These changes affect not only the executor definitions but also several jobs that have been updated to use the new python314 executor.
|
|
||
| python313: | ||
| docker: | ||
| - image: python:3.13.12 |
There was a problem hiding this comment.
The Docker image python:3.13.12 does not exist. Python 3.13 is currently in a pre-release state. To test against it, you should use a valid pre-release tag from Docker Hub, for example python:3.13-rc. Using an invalid tag will cause the build to fail.
- image: python:3.13-rc|
|
||
| python314: | ||
| docker: | ||
| - image: python:3.14.3 |
There was a problem hiding this comment.
The Docker image python:3.14.3 does not exist, as Python 3.14 is not scheduled for its first alpha release until 2025. Using this will break the CI pipeline. I recommend removing the python314 executor and its usages throughout the file for now.
| python-integration: | ||
| docker: | ||
| - image: python:3.12.12 | ||
| - image: python:3.14.3 |
There was a problem hiding this comment.
This job uses the non-existent python:3.14.3 Docker image, which will cause the CI to fail. This should be reverted to a valid image, for example python:3.12.12 as it was before, or another stable version.
- image: python:3.12.12| jobs: | ||
| build-rest: | ||
| executor: python312 | ||
| executor: python314 |
There was a problem hiding this comment.
This job is configured to use the python314 executor, which is based on a non-existent Docker image. This will cause the job to fail. Please revert this to use a valid executor like python312.
executor: python312| # path which breaks the tag filter). | ||
| poetry-publish-workspace: | ||
| executor: python312 | ||
| executor: python314 |
There was a problem hiding this comment.
This job is configured to use the python314 executor, which is based on a non-existent Docker image. This will cause the job to fail. Please revert this to use a valid executor like python312.
executor: python312|
|
||
| docs: | ||
| executor: python312 | ||
| executor: python314 |
There was a problem hiding this comment.
This job is configured to use the python314 executor, which is based on a non-existent Docker image. This will cause the job to fail. Please revert this to use a valid executor like python312.
executor: python312| parameters: | ||
| cwd: [auth, bigquery, datastore, kms, pubsub, storage, taskqueue] | ||
| executor: [python310, python311, python312] | ||
| executor: [python310, python311, python312, python313, python314] |
There was a problem hiding this comment.
The python314 executor is being added to the test matrix, but it is based on a non-existent Docker image. This will cause these matrix jobs to fail. Please remove python314 from this list.
executor: [python310, python311, python312, python313]| parameters: | ||
| cwd: [/rest/auth, /rest/bigquery, /rest/datastore, /rest/kms, /rest/pubsub, /rest/storage, /rest/taskqueue] | ||
| executor: [python310, python311, python312] | ||
| executor: [python310, python311, python312, python313, python314] |
There was a problem hiding this comment.
The python314 executor is being added to the test matrix, but it is based on a non-existent Docker image. This will cause these matrix jobs to fail. Please remove python314 from this list.
executor: [python310, python311, python312, python313]1 participant
Summary
Add 3.13 and 3.14 to our matrix targets.
Blocked on #1000.