feat(auth): external credential type in auth#906
Open
Prahathess (rakshasa-1729) wants to merge 3 commits intotalkiq:masterfrom
Open
feat(auth): external credential type in auth#906Prahathess (rakshasa-1729) wants to merge 3 commits intotalkiq:masterfrom
Prahathess (rakshasa-1729) wants to merge 3 commits intotalkiq:masterfrom
Conversation
Prahathess (rakshasa-1729)
requested review from
a team,
Kevin James (TheKevJames) and
cphoward
as code owners
Prahathess (rakshasa-1729)
requested review from
Kelly Ma (eddiedialpad),
Gabija Balvociute (gabija-dialpad) and
Olivia Fernandez (olidp)
and removed request for
a team
Author
|
Kevin James (@TheKevJames) Could use some help triggering the integration tests once |
|
Hi any ETA here? |
Çağatay Gürtürk (cagataygurturk)
suggested changes
Jul 15, 2025
| """Get the subject token from the credential source.""" | ||
| source_type = credential_source.get('type') | ||
| if not source_type: | ||
| raise ValueError('Credential source missing type') |
There was a problem hiding this comment.
Hi, the source_type property is not mandatory as far as I understand. When we download a configuration file, this is what we get:
{
"universe_domain": "googleapis.com",
"type": "external_account",
"audience": "WORKLOAD_IDENTITY_PROVIDER_ID",
"subject_token_type": "urn:ietf:params:oauth:token-type:jwt",
"token_url": "https://sts.googleapis.com/v1/token",
"credential_source": {
"file": "/var/run/secrets/kubernetes.io/serviceaccount/token",
"format": {
"type": "text"
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #578
Adds support for the external_account service account type, which is used in Workload Identity Federation.