Skip to content

chore(auth): upgrade chardet dependency upper bound to < 8.0#1010

Open
Gregory L (glinf) wants to merge 1 commit intotalkiq:masterfrom
glinf:chore/upgrade-chardet
Open

chore(auth): upgrade chardet dependency upper bound to < 8.0#1010
Gregory L (glinf) wants to merge 1 commit intotalkiq:masterfrom
glinf:chore/upgrade-chardet

Conversation

@glinf
Copy link

@glinf Gregory L (glinf) commented Mar 16, 2026

Summary

Raises the chardet dependency upper bound from < 7.0 to < 8.0 to allow chardet 7.x.

Motivation:

  • chardet 7.1.0 brings performance improvements
  • License changed to MIT (more permissive)
  • API is stable across the existing range, no breaking changes

Updates both pyproject.toml and pyproject.rest.toml (via bin/build-rest), along with their respective lock files.

Would also solve #785

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine dependency update for chardet, a universal encoding detector. The primary goal is to modernize the project's dependencies by allowing newer versions of chardet, which offer enhanced performance and a more flexible license. The changes are confined to the project's dependency configuration and lock files, ensuring stability while benefiting from upstream improvements.

Highlights

  • Dependency Upgrade: The chardet dependency range has been updated from >= 2.0, < 7.0 to >= 5.0, < 8.0 in both pyproject.toml and pyproject.rest.toml.
  • Performance and Licensing: This upgrade allows for the use of chardet versions up to 7.x, which brings performance improvements and a more permissive MIT license.
  • Lock File Updates: The poetry.lock and poetry.rest.lock files were updated to reflect the new chardet version (6.0.0.post1), along with charset-normalizer (3.4.6) and pyjwt (2.12.1), and their associated content hashes and Python version requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • auth/poetry.lock
    • Updated the Poetry version from 2.3.2 to 2.1.3.
    • Updated the content hash.
  • auth/poetry.rest.lock
    • Updated the Poetry version from 2.3.2 to 2.1.3.
    • Updated chardet from version 5.2.0 to 6.0.0.post1 and adjusted its Python version requirement to >=3.10.
    • Updated charset-normalizer from version 3.4.4 to 3.4.6.
    • Updated pyjwt from version 2.11.0 to 2.12.1 and added typing_extensions as a dependency for Python versions less than 3.11.
    • Updated the content hash.
  • auth/pyproject.rest.toml
    • Updated the chardet dependency range from >= 2.0, < 7.0 to >= 5.0, < 8.0.
  • auth/pyproject.toml
    • Updated the chardet dependency range from >= 2.0, < 7.0 to `>= 5.0, < 8.0'.
Activity
  • No human activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment Gemini (@gemini-code-assist) Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the chardet dependency range in pyproject.toml and pyproject.rest.toml. The accompanying lock file changes reflect this upgrade. However, both lock files appear to have been generated with an older version of Poetry (2.1.3) than was previously used (2.3.2). This version downgrade could cause dependency inconsistencies for other developers and should be rectified by regenerating the lock files with the more recent Poetry version.

Raise the upper bound from < 7.0 to < 8.0 to allow chardet 7.x which
brings performance improvements and a more permissive MIT license.
@glinf Gregory L (glinf) changed the title chore(auth): upgrade chardet dependency to >= 5.0, < 8.0 chore(auth): upgrade chardet dependency upper bound to < 8.0 Mar 16, 2026
@glinf Gregory L (glinf) marked this pull request as ready for review March 16, 2026 13:16
@glinf Gregory L (glinf) requested review from Kelly Ma (eddiedialpad) and Shaun Sawyer (shaundialpad) and removed request for a team March 16, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant