Fix reward scaler when run on varied episode lengths#455
Merged
takuseno merged 1 commit intotakuseno:masterfrom May 25, 2025
Merged
Conversation
When calling `fit` with a reward scaler on a dataset with varied episode lengths, the following error would be thrown in the `fit_with_trajectory_slicer` method: ``` ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. ``` This commit fixes the issue by flattening the rewards before calculating the mean and std.
takuseno
approved these changes
May 25, 2025
Owner
takuseno
left a comment
takuseno
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454
When calling
fitwith a reward scaler on a dataset with varied episode lengths, the following error would be thrown in thefit_with_trajectory_slicermethod:This commit fixes the issue by flattening the rewards before calculating the mean and std.