fix(compat): map maxWidth to max-width namespace in v4 migration#19653
Open
NssGourav wants to merge 2 commits intotailwindlabs:mainfrom
Open
fix(compat): map maxWidth to max-width namespace in v4 migration#19653NssGourav wants to merge 2 commits intotailwindlabs:mainfrom
NssGourav wants to merge 2 commits intotailwindlabs:mainfrom
Conversation
Contributor
WalkthroughThis pull request updates the CSS property namespace mapping in the apply-config-to-theme module. The 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Tailwind CSS v4, the migration logic for v3 configurations incorrectly maps the
maxWidththeme key to the--container-*CSS variable namespace. This causes clashes with container query variables and breaks the primarymax-w-*utility design.This PR updates
OLD_TO_NEW_NAMESPACEto correctly mapmaxWidthtomax-width.Fixes #19555
Test Plan
Verified by updating existing core compatibility tests.
Execution command: