Skip to content

fix: validate position in sys_pread64 and sys_pwrite64 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marsman1996 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate position in sys_pread64 and sys_pwrite64 #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/ruxos_posix_api/src/imp/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ pub fn sys_pread64(
) -> ctypes::ssize_t {
syscall_body!(sys_pread64, {
debug!("sys_pread64 <= {fd} {count} {pos}");
if pos < 0 {
return Err(LinuxError::EINVAL);
}
if buf.is_null() {
return Err(LinuxError::EFAULT);
}
Expand All @@ -93,6 +96,9 @@ pub fn sys_pwrite64(
) -> ctypes::ssize_t {
syscall_body!(sys_pwrite64, {
debug!("sys_pwrite64 <= {fd} {count} {pos}");
if pos < 0 {
return Err(LinuxError::EINVAL);
}
if buf.is_null() {
return Err(LinuxError::EFAULT);
}
Expand Down
Loading