Open
Conversation
lhw2002426
force-pushed
the
add_rng
branch
3 times, most recently
from
e929b30 to
23519af
Compare
ken4647
reviewed
Jul 21, 2025
Contributor
|
A lot of warnings when |
Contributor
|
try to change commit message to |
Contributor
|
Contributor
|
you need to fix clippy before go next step |
ken4647
reviewed
Jul 21, 2025
| false => return rand_lcg32() as c_int, | ||
| } | ||
| } | ||
| rand_lcg32() as c_int |
Contributor
There was a problem hiding this comment.
warning: unreachable expression
--> api/ruxos_posix_api/src/imp/getrandom.rs:133:5
|
128 | / match has_rdrand() {
129 | | true => return (random_hw() >> 33) as c_int,
130 | | false => return rand_lcg32() as c_int,
131 | | }
| |_________- any code following this `match` expression is unreachable, as all arms diverge
132 | }
133 | rand_lcg32() as c_int
| ^^^^^^^^^^^^^^^^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
warning: unreachable expression
--> api/ruxos_posix_api/src/imp/getrandom.rs:152:5
|
146 | / match has_rdrand() {
147 | | true => return (random_hw() >> 1) as c_long,
148 | | false => return random_lcg64() as c_long,
149 | | }
| |_________- any code following this `match` expression is unreachable, as all arms diverge
...
152 | random_lcg64() as c_long
| ^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression
modules/ruxdriver/src/dummy.rs
Outdated
| fn info(&self) -> driver_rng::RngInfo { | ||
| unreachable!() | ||
| } | ||
| fn request_entropy(&mut self, dst: &mut [u8]) -> DevResult<usize> { |
Contributor
There was a problem hiding this comment.
warning: unused variable: `dst`
--> modules/ruxdriver/src/dummy.rs:135:43
|
135 | fn request_entropy(&mut self, dst: &mut [u8]) -> DevResult<usize> {
| ^^^ help: if this is intentional, prefix it with an underscore: `_dst`
|
= note: `#[warn(unused_variables)]` on by default
modules/ruxruntime/src/lib.rs
Outdated
| let all_devices = ruxdriver::init_drivers(); | ||
|
|
||
| #[cfg(feature = "rng")] | ||
| ruxrand::init(all_devices.rng, cpu_id); |
Contributor
There was a problem hiding this comment.
as you move ruxrand::init(cpu_id); there, it won't be initiazed when feature=rand is enabled, are you sure is it right. What will happen if rng is enabled without a virtio-rng?
Contributor
Author
There was a problem hiding this comment.
If run with RNG=y but without FEATURE virtio-rng It will raise an error that there is no rng.
crates/driver_rng/src/xoshiro.rs
Outdated
| type PercpuRngType = Xoshiro256StarStar; | ||
|
|
||
| #[def_percpu] | ||
| pub(crate) static PERCPU_RNG: LazyInit<PercpuRngType> = LazyInit::new(); |
Contributor
There was a problem hiding this comment.
The code structure here is too similar to ruxrand, and it seems to involve almost no virtio hardware, so there's no hardware abstraction. It's also hard to see the necessity of this...
Contributor
There was a problem hiding this comment.
To be precise, I believe this crate should only retain a lib.rs file. The other two pseudo-random number generators should be placed together within ruxrand; otherwise, it could easily cause confusion.
lhw2002426
force-pushed
the
add_rng
branch
3 times, most recently
from
e736934 to
716af40
Compare
lhw2002426
force-pushed
the
add_rng
branch
4 times, most recently
from
b957f0e to
dbca725
Compare
ken4647
reviewed
Sep 3, 2025
ken4647
reviewed
Sep 3, 2025
ken4647
reviewed
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add rng device and virtio rng