Skip to content

add email-italic test#15

Open
bertho-zero wants to merge 1 commit intosyntax-tree:mainfrom
bertho-zero:bug-italic-email
Open

add email-italic test#15
bertho-zero wants to merge 1 commit intosyntax-tree:mainfrom
bertho-zero:bug-italic-email

Conversation

@bertho-zero
Copy link
Copy Markdown

@bertho-zero bertho-zero commented Jan 22, 2025

Hi, I added a test that shows that an email at the beginning of an italic text is not transformed correctly.

Input:

_support@example.com to contact support_

Output:

<p><a href="mailto:_support@example.com">_support@example.com</a> to contact support_</p>

Expected:

<p><em><a href="support@example.com">support@example.com</a> to contact support</em></p>

Gfm example:

support@example.com to contact support

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jan 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 22, 2025

Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source):

I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done!

Thanks,
— bb

@wooorm
Copy link
Copy Markdown
Member

wooorm commented Jan 23, 2025

GFM works weirdly and does this one different than all other things. This cannot normally be solved. It would be solved by https://github.com/micromark/micromark-extension-gfm-autolink-literal/blob/618170c86639742036ecf666d975a6ebac5aac50/dev/lib/syntax.js#L76-L79.

@bertho-zero
Copy link
Copy Markdown
Author

Hi,

Thanks for your answer, is this something that is planned soon or is it not a priority?

@wooorm
Copy link
Copy Markdown
Member

wooorm commented Mar 3, 2025

The work here is done on a volunteer basis, or, when there’s enough funding, I get to things across the collective. This particular problem is complex. So, you can either try your hand at it, or, sponsor the projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👋 phase/new Post is being triaged automatically

Development

Successfully merging this pull request may close these issues.

2 participants